[Mesa-dev] [PATCH 11/25] i965: Add support for disassembling 64-bit integer immediates

Matt Turner mattst88 at gmail.com
Fri Aug 4 17:31:43 UTC 2017


After the last patch converted things into enums, I helpfully got a
compiler warning about these missing from the switch statement.
---
 src/intel/compiler/brw_disasm.c | 6 ++++++
 src/intel/compiler/brw_inst.h   | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c
index b5c283058a..6da7060517 100644
--- a/src/intel/compiler/brw_disasm.c
+++ b/src/intel/compiler/brw_disasm.c
@@ -1029,6 +1029,12 @@ imm(FILE *file, const struct gen_device_info *devinfo, enum hw_imm_type type,
     const brw_inst *inst)
 {
    switch (type) {
+   case GEN8_HW_IMM_TYPE_UQ:
+      format(file, "0x%16lxUD", brw_inst_imm_uq(devinfo, inst));
+      break;
+   case GEN8_HW_IMM_TYPE_Q:
+      format(file, "%ldD", brw_inst_imm_uq(devinfo, inst));
+      break;
    case BRW_HW_IMM_TYPE_UD:
       format(file, "0x%08xUD", brw_inst_imm_ud(devinfo, inst));
       break;
diff --git a/src/intel/compiler/brw_inst.h b/src/intel/compiler/brw_inst.h
index 5b2ce32ae4..cd3b0e95ea 100644
--- a/src/intel/compiler/brw_inst.h
+++ b/src/intel/compiler/brw_inst.h
@@ -569,6 +569,13 @@ brw_inst_imm_ud(const struct gen_device_info *devinfo, const brw_inst *insn)
    return brw_inst_bits(insn, 127, 96);
 }
 
+static inline uint64_t
+brw_inst_imm_uq(const struct gen_device_info *devinfo, const brw_inst *insn)
+{
+   assert(devinfo->gen >= 8);
+   return brw_inst_bits(insn, 127, 64);
+}
+
 static inline float
 brw_inst_imm_f(const struct gen_device_info *devinfo, const brw_inst *insn)
 {
-- 
2.13.0



More information about the mesa-dev mailing list