[Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

Jan Vesely jan.vesely at rutgers.edu
Fri Aug 4 18:51:02 UTC 2017


I went through most of the series. I think the approach is OK. The
biggest issue I had is with the sequence:
1.) add an interface
2.) implement a feature
3.) change the interface

I gave my rb to 1 and 2, but you might want to consider changing them
as well, if returning int from the functions is better. Generating
string is IMO easier/faster than parsing them.

Also, you might want to consider cc'ing Francisco as he'll have the
final say and might see things differently.


On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
> I've dropped the first patch of the previous series for now. I'm not
> withdrawing it completely, just going to see if there's anything about
> the user_ptr stuff that could have been causing the issue instead, and
> if I'm using too big a hammer in this patch. If I convince myself of its
> correctness, it'll be back.
> The rest of the patches move the device version declaration to core/device
> and then use that along with the -cl-std option to determine which
> OpenCL language version to enable in clang.
> I've done a full piglit run (again) before/after, and there are no changes
> for me on radeonsi/pitcairn if the device is left at CL 1.1.
> When I bump my platform/device versions to 1.2, the clang instance has
> been confirmed to enable 1.2 language features (like the static keyword
> required in test/cl/program/execute/static.cl, which goes skip->pass).
> Major changes since v1:
>   Addressed Pierre's build-breakage comments
>   Added a check for cl-std > device_clc_version
>   Added a patch to pass the device object down into invocation.cpp
>     instead of adding a bunch of device-based arguments.
>   Use device_clc_version for cl version detection instead of device_version
>   Added device_clc_version in device.cpp/hpp
> Anyway, happy reviewing.
> Cc: Jan Vesely <jan.vesely at rutgers.edu>
> Cc: Pierre Moreau <pierre.morrow at free.fr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170804/f3c626f0/attachment.sig>

More information about the mesa-dev mailing list