[Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

Kenneth Graunke kenneth at whitecape.org
Sun Aug 6 18:09:07 UTC 2017


On Thursday, August 3, 2017 9:52:37 AM PDT Jason Ekstrand wrote:
> The make_shareable function deletes the aux buffer and then whacks
> aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear.
> Since we only look at supports_fast_clear to decide whether or not to do
> fast clears, this was causing assertion failures.
> 
> Reported-by: Tapani Pälli <tapani.palli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 17ac563..6fca7e3 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2706,6 +2706,7 @@ intel_miptree_make_shareable(struct brw_context *brw,
>     }
>  
>     mt->aux_usage = ISL_AUX_USAGE_NONE;
> +   mt->supports_fast_clear = false;
>  }
>  
>  
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170806/b2563c42/attachment.sig>


More information about the mesa-dev mailing list