[Mesa-dev] [PATCH 2/2] TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture

Iago Toral Quiroga itoral at igalia.com
Mon Aug 7 04:18:24 UTC 2017


Previous behavior was inconsistent with other texture targets so this has been
fixed in OpenGL 4.6.

Fixes:
KHR-GL45.direct_state_access.textures_storage_errors
---
 src/mesa/main/texstorage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
index e0930abe3f..44edba3323 100644
--- a/src/mesa/main/texstorage.c
+++ b/src/mesa/main/texstorage.c
@@ -605,7 +605,7 @@ texturestorage_error(GLuint dims, GLuint texture, GLsizei levels,
     * can receive unsized formats.
     */
    if (!legal_texobj_target(ctx, dims, texObj->Target)) {
-      _mesa_error(ctx, GL_INVALID_ENUM,
+      _mesa_error(ctx, GL_INVALID_OPERATION,
                   "%s(illegal target=%s)", caller,
                   _mesa_enum_to_string(texObj->Target));
       return;
-- 
2.11.0



More information about the mesa-dev mailing list