[Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

Ian Romanick idr at freedesktop.org
Mon Aug 7 22:31:21 UTC 2017


On 08/07/2017 03:20 PM, Ilia Mirkin wrote:
> On Mon, Aug 7, 2017 at 6:14 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 06/28/2017 06:50 AM, Plamena Manolova wrote:
>>> ARB_polygon_offset_clamp is just the ARB variation
>>> of EXT_polygon_offset_clamp and they operate in an
>>> identical manner, so there's no reason for us not
>>> to advertise it.
>>>
>>> Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
>>> ---
>>>  src/mesa/main/extensions_table.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
>>> index 757b7bf..8286c76 100644
>>> --- a/src/mesa/main/extensions_table.h
>>> +++ b/src/mesa/main/extensions_table.h
>>> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query           , ARB_pipeline_statistics_query
>>>  EXT(ARB_pixel_buffer_object                 , EXT_pixel_buffer_object                , GLL, GLC,  x ,  x , 2004)
>>>  EXT(ARB_point_parameters                    , EXT_point_parameters                   , GLL,  x ,  x ,  x , 1997)
>>>  EXT(ARB_point_sprite                        , ARB_point_sprite                       , GLL, GLC,  x ,  x , 2003)
>>> +EXT(ARB_polygon_offset_clamp                , EXT_polygon_offset_clamp               , GLL, GLC, ES1, ES2, 2017)
>>
>> This should be                                                                            GLL, GLC,  x,   x,  2017
>>
>> With that fixed and docs/features.txt updated, this patch is
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> Should probably hook up the dispatch for the function too... and
> update headers so that what we're shipping includes the bits for the
> exts we're exposing.

You are, of course, correct.  I was thinking that this extension just
added an enum like ARB_texture_filter_anisotropic.

>   -ilia


More information about the mesa-dev mailing list