[Mesa-dev] [PATCH 7/8] egl/drm: remove unreachable code in dri2_drm_create_surface()

[Emil Velikov]

On 8 August 2017 at 17:34, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Saturday, 2017-08-05 00:25:52 +0100, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> The function can be called only when the type is EGL_WINDOW_BIT.
>> Remove the unneeded switch statement.
>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  src/egl/drivers/dri2/platform_drm.c | 20 +++++++-------------
>>  1 file changed, 7 insertions(+), 13 deletions(-)
>>
>> diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c
>> index 7ea43e62010..8d56fcb7698 100644
>> --- a/src/egl/drivers/dri2/platform_drm.c
>> +++ b/src/egl/drivers/dri2/platform_drm.c
>> @@ -92,13 +92,13 @@ has_free_buffers(struct gbm_surface *_surf)
>>
>>  static _EGLSurface *
>>  dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type,
>> -                        _EGLConfig *conf, void *native_window,
>> +                        _EGLConfig *conf, void *native_surface,
>>                          const EGLint *attrib_list)
>>  {
>>     struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp);
>>     struct dri2_egl_config *dri2_conf = dri2_egl_config(conf);
>>     struct dri2_egl_surface *dri2_surf;
>> -   struct gbm_surface *window = native_window;
>> +   struct gbm_surface *window = native_surface;
>
> Why not rename `window` too?
>
Fixed-up locally.

> Regardless:
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
>
Thanks
Emil