[Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

Tapani Pälli tapani.palli at intel.com
Wed Aug 9 15:41:34 UTC 2017

On 08/09/2017 12:30 PM, Eric Engestrom wrote:
> On Wednesday, 2017-08-09 08:35:04 +0300, Tapani Pälli wrote:
>> On 08/08/2017 08:07 PM, Emil Velikov wrote:
>>> On 8 August 2017 at 16:10, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>>>> On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote:
>>>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>>> As mentioned in previous commit the negative tests in dEQP expect the
>>>>> arguments to be evaluated in particular order.
>>>> The spec doesn't say that, so the test is wrong.
>>>> Changing it in Mesa doesn't hurt though, so I have nothing against it,
>>>> except for the fact it hide the dEQP bug.
>>> I agree, the spec does not say anything on the topic.
>>> I think it makes sense to have the patch regardless, since it provides
>>> a bit more consistency.
>>> Although fixing dEQP is also a good idea. I think Tapani/Chad have
>>> some experience/pointers on the topic.
>> You can send patches to gerrit in same manner just like for rest of Android,
>> then assign reviewers from people that have committed to dEQP. I can help
>> trying to get those fixes forward. You should work on master branch though,
>> what I've experienced is that getting fixes to some specific release branch
>> is a lot more difficult matter.
> This is to submit fixes though, which I don't always have the time or
> knowledge to do myself. I was hoping there would be a way to report
> "this is wrong because X" and let someone else figure out the fix.
> Is there any bug/issue tracker for deqp?

I'm not aware of one :/

// Tapani

More information about the mesa-dev mailing list