[Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

[Emil Velikov]

Hi Thomas,

Apologies for dropping in so late.

On 9 August 2017 at 10:53, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> The attribMap had two entries for this attribute, and
> driGetConfigAttribIndex didn't return a proper value for this attribute.
> Fix this, and also make sure we return SWAP_UNDEFINED for single-buffer
> configs as required by the GLX_OML_swap_method spec.
>
> Finally bump the dri core extension version to 2, indicating that we
> correctly report __DRI_ATTRIB_SWAP_METHOD.
>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> ---
>  include/GL/internal/dri_interface.h    | 5 ++++-
>  src/mesa/drivers/dri/common/dri_util.c | 2 +-
>  src/mesa/drivers/dri/common/utils.c    | 8 ++------
>  3 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h
> index f676ac5..5e8fce7 100644
> --- a/include/GL/internal/dri_interface.h
> +++ b/include/GL/internal/dri_interface.h
> @@ -726,9 +726,12 @@ struct __DRIuseInvalidateExtensionRec {
>
>  /**
>   * This extension defines the core DRI functionality.
> + *
> + * Version >= 2 indicates that getConfigAttrib with __DRI_ATTRIB_SWAP_METHOD
> + * returns a reliable value.
>   */
>  #define __DRI_CORE "DRI_Core"
> -#define __DRI_CORE_VERSION 1
> +#define __DRI_CORE_VERSION 2
>
The interface is bumped, yet nobody checks it.

If I understand your series correctly, when old drivers are present we
fallback to UNDEFINED and things should just work.
Hence the version bump isn't really needed.

Am I missing something?

Thanks
Emil