[Mesa-dev] [PATCH 00/13] clang warning fixes

Jordan Justen jordan.l.justen at intel.com
Thu Aug 10 23:22:40 UTC 2017


Where's the patchlist on your cover letter? :)

1: Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

2: If only changing the string calls:
   Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

3-5: Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

6-8: Do you have data that removing the inlines doesn't hurt things?
     ;) I actually don't have an opinion on these, so I'll hold off
     to see if anyone else chimes in.

9: Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
   (Noting that you are changing an inline function. ;)

10-13: Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2017-08-10 15:02:31, Matt Turner wrote:
> Just a simple series cleaning up various bits of code that clang warns about.
> 
> The only real change is to "i965/vec4: Return float from spill_cost_for_type()" which fixes an obvious mistake. The rest just cleans things up like marking internal functions static.
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list