[Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

Jason Ekstrand jason at jlekstrand.net
Mon Aug 14 18:42:43 UTC 2017


I missed the stable CC when I pushed this one.  It needs to be in 17.2

On Thu, Aug 3, 2017 at 9:52 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:

> The make_shareable function deletes the aux buffer and then whacks
> aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear.
> Since we only look at supports_fast_clear to decide whether or not to do
> fast clears, this was causing assertion failures.
>
> Reported-by: Tapani Pälli <tapani.palli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 17ac563..6fca7e3 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2706,6 +2706,7 @@ intel_miptree_make_shareable(struct brw_context
> *brw,
>     }
>
>     mt->aux_usage = ISL_AUX_USAGE_NONE;
> +   mt->supports_fast_clear = false;
>  }
>
>
> --
> 2.5.0.400.gff86faf
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170814/79bc8e5a/attachment-0001.html>


More information about the mesa-dev mailing list