[Mesa-dev] [PATCH] configure: Check llvm-config --shared-mode

[Michel Dänzer]

On 15/08/17 12:00 PM, Aaron Watry wrote:
> On Mon, Aug 14, 2017 at 7:54 PM, Michel Dänzer <michel at daenzer.net> wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> https://bugs.llvm.org/show_bug.cgi?id=6823 still affects current LLVM.
>> llvm-config --libs only reports the single shared library if LLVM was
>> built with -DLLVM_LINK_LLVM_DYLIB=ON. llvm-config --shared-mode reports
>> "shared" in that case, "static" otherwise (even if LLVM was built with
>> -DLLVM_BUILD_LLVM_DYLIB=ON).
>>
>> Fixes: 3d8da1f678e1 ("configure: Trust LLVM >= 4.0 llvm-config --libs
>>                       for shared libraries")
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Thanks Michel,
> 
> Fixes a build error I've been encountering tonight with all of the
> combinations of llvm builds I've tried (VC_REV=on/off,
> shared_libraries=1/0, dylib=1/0
> 
> Tested-by: Aaron Watry <awatry at gmail.com>
> 
> FYI: I've settled for now on LLVM_APPEND_VC_REV=ON,
> BUILD_SHARED_LIBS=1 amongst the rest of my llvm build flags.
> Previously, I was able to get away with VC_REV=off,
> LLVM_BULID_LLVM_DYLIB=1.

The latter should work again with this patch. I'm using
LLVM_BULID_LLVM_DYLIB=ON LLVM_LINK_LLVM_DYLIB=ON, the latter removes the
need for LLVM_APPEND_VC_REV=OFF with my patches.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer