[Mesa-dev] [PATCH 3/4] radeonsi: remove INCREMENT_DE_COUNTER

Nicolai Hähnle nhaehnle at gmail.com
Wed Aug 16 11:13:41 UTC 2017


From: Nicolai Hähnle <nicolai.haehnle at amd.com>

We don't actually ever use the DE counter for synchronization.
---
 src/gallium/drivers/radeonsi/si_compute.c    |  2 --
 src/gallium/drivers/radeonsi/si_state.h      |  1 -
 src/gallium/drivers/radeonsi/si_state_draw.c | 10 ----------
 3 files changed, 13 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c
index d0e481a3f15..3d1161b6e1f 100644
--- a/src/gallium/drivers/radeonsi/si_compute.c
+++ b/src/gallium/drivers/radeonsi/si_compute.c
@@ -848,8 +848,6 @@ static void si_launch_grid(
 
 	si_emit_dispatch_packets(sctx, info);
 
-	si_ce_post_draw_synchronization(sctx);
-
 	if (unlikely(sctx->current_saved_cs))
 		si_trace_emit(sctx);
 
diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h
index bce40663085..57d074c1a7f 100644
--- a/src/gallium/drivers/radeonsi/si_state.h
+++ b/src/gallium/drivers/radeonsi/si_state.h
@@ -402,7 +402,6 @@ void si_get_active_slot_masks(const struct tgsi_shader_info *info,
 void si_init_ia_multi_vgt_param_table(struct si_context *sctx);
 void si_emit_cache_flush(struct si_context *sctx);
 void si_ce_pre_draw_synchronization(struct si_context *sctx);
-void si_ce_post_draw_synchronization(struct si_context *sctx);
 void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *dinfo);
 void si_trace_emit(struct si_context *sctx);
 
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c
index b0d2c127fa1..ce92fce0725 100644
--- a/src/gallium/drivers/radeonsi/si_state_draw.c
+++ b/src/gallium/drivers/radeonsi/si_state_draw.c
@@ -1150,14 +1150,6 @@ void si_ce_pre_draw_synchronization(struct si_context *sctx)
 
 		radeon_emit(sctx->b.gfx.cs, PKT3(PKT3_WAIT_ON_CE_COUNTER, 0, 0));
 		radeon_emit(sctx->b.gfx.cs, 0); /* 0 = don't flush sL1 conditionally */
-	}
-}
-
-void si_ce_post_draw_synchronization(struct si_context *sctx)
-{
-	if (sctx->ce_need_synchronization) {
-		radeon_emit(sctx->b.gfx.cs, PKT3(PKT3_INCREMENT_DE_COUNTER, 0, 0));
-		radeon_emit(sctx->b.gfx.cs, 0); /* unused */
 
 		sctx->ce_need_synchronization = false;
 	}
@@ -1437,8 +1429,6 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
 		si_emit_draw_packets(sctx, info, indexbuf, index_size, index_offset);
 	}
 
-	si_ce_post_draw_synchronization(sctx);
-
 	if (unlikely(sctx->current_saved_cs))
 		si_trace_emit(sctx);
 
-- 
2.11.0



More information about the mesa-dev mailing list