[Mesa-dev] [PATCH 0/3] mesa: Modify drirc options

[Nicolai Hähnle]

Hi Quentin,

Glad you got your email configuration sorted out, and those are some 
nice changes!

There are some changes that should be done before this can go to upstream.

The Mesa policy is that your Git name has to be your real name, and 
AFAIU QuRyu is more of a screen name. After you change your git config, 
you can use git commit --amend --reset-author to update the author name 
of a commit.

The first two patches should be combined into a single patch: when the 
type of the options is changed, their default values should be changed 
simultaneously. Otherwise, if only the first patch is applied, there is 
an inconsistency.

For a similar reason, patch #3 should actually come first. Otherwise, 
after only the first two patches are applied, there would be the 
compatibility issue that patch #3 fixes.

The general rule is that each individual patch should leave the code in 
a consistent and working state. This is mostly motivated by trying to 
make sure that `git bisect` works as well as possible.

I have some additional comments on patch #3, which I'm sending in a 
separate reply.

This is already looking quite good, but please make those changes and 
send a v2 version of the patch series!

Cheers,
Nicolai


On 17.08.2017 04:20, QuRyu wrote:
> This serie of patches changes drirc's semanticaclly boolean options, options that are enum type options but which in essence are boolean options e.g. pp_shalde, into actual boolean optioinns.
> 
> Backwawrd compatbility is maintained by relaxinig xmlconfig parser so that xml files before this change can still be parsed correctly.
> Driconf, unfortunately, will be affected by this. The issue will be addressedd later by releasing a new version of Driconf.
> 
> Also note that these changes are made to fulfil requirementss to participate in EVoC (Endless Vacaction of Code) hosted by X.org.
> 
> QuRyu (3):
>    mesa: Modify type of drirc options
>    mesa: Modify drirc's default option values
>    mesa: Fix backward compatbility for XML parser
> 
>   .../auxiliary/pipe-loader/driinfo_gallium.h        |  8 ++++----
>   src/util/xmlconfig.c                               | 22 ++++++++++++++++++++--
>   src/util/xmlpool/t_options.h                       |  8 ++++----
>   3 files changed, 28 insertions(+), 10 deletions(-)
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.