[Mesa-dev] [PATCH 2/2] intel/isl: Replace switch statements of doom with a macro

Kenneth Graunke kenneth at whitecape.org
Thu Aug 17 22:09:33 UTC 2017


On Thursday, August 17, 2017 2:57:17 PM PDT Jason Ekstrand wrote:
>  void
>  isl_buffer_fill_state_s(const struct isl_device *dev, void *state,
>                          const struct isl_buffer_fill_state_info *restrict info)
>  {
> -   switch (ISL_DEV_GEN(dev)) {
> -   case 4:
> -   case 5:
> -      /* Gen 4-5 are all the same when it comes to buffer surfaces */

This will make us actually use the gen4 function.  That seems good.

Thanks for removing this handwritten stuff.  Both are:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170817/59c1621d/attachment.sig>


More information about the mesa-dev mailing list