[Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

[Timothy Arceri]

On 18/08/17 11:00, Kenneth Graunke wrote:
> On Thursday, August 17, 2017 4:41:52 PM PDT Timothy Arceri wrote:
>> On 18/08/17 08:30, Kenneth Graunke wrote:
>>> On Tuesday, August 15, 2017 3:42:29 AM PDT Timothy Arceri wrote:
>>>> Gallium drivers use this code path so we need to account for
>>>> bindless after all.
>>>
>>> Why do Gallium drivers use ir_to_mesa?  That seems like a misfeature.
>>
>> Because Gallium drivers still use paramlist for uniforms. I'm sure we
>> could duplicate the code (most of glsl->tgsi seems to be copied from
>> ir_to_mesa at some point), it just doesn't seem to have been done for
>> whatever reason.
> 
> i965 still uses paramlist for a bunch of uniforms too.

Only for asm programs if I recall correctly.

>  You do need to
> duplicate some logic, but you get to drop piles of it too.

Not really, not unless every Gallium driver is updated to handled packed 
uniforms :)

>  It might
> be worth looking at brw_link.cpp...
> 

I'm working on a series to support packed uniforms, which reduces a 
bunch of CPU overhead. It still uses paramlist but it's a stepping stone.