[Mesa-dev] [PATCH 2/9] loader_dri3/glx/egl: Optionally use a blit context for blitting operations

[Emil Velikov]

Hi Thomas,

On 15 August 2017 at 19:31, Thomas Hellstrom <thellstrom at vmware.com> wrote:

> +/**
> + * A cached blit context.
> + */
> +struct loader_dri3_blit_context {
> +   mtx_t mtx;
> +   __DRIcontext *ctx;
> +   __DRIscreen *cur_screen;
> +   const __DRIcoreExtension *core;
> +};
> +
> +/* For simplicity we maintain the cache only for a single screen at a time */
> +static struct loader_dri3_blit_context blit_context = {
> +   _MTX_INITIALIZER_NP, NULL
Use a C99 designated initializer?

> +};

> +/**
> + * Blit (parts of) the contents of a DRI image to another dri image
> + *
> + * \param draw[in]  The drawable which owns the images.
> + * \param dst[in]  The destination image.
> + * \param src[in]  The source image.
> + * \param dstx0[in]  Start destination coordinate.
> + * \param dsty0[in]  Start destination coordinate.
> + * \param width[in]  Blit width.
> + * \param height[in] Blit height.
> + * \param srcx0[in]  Start source coordinate.
> + * \param srcy0[in]  Start source coordinate.
> + * \param flush_flag[in]  Image blit flush flag.
> + * \return true iff successful.
s/iff/if/

With the above
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Please don't bother re-sending the patch. Squash locally before pushing.

Thanks
Emil