[Mesa-dev] [PATCH 1/2] i965: Issue performance warnings when growing the program cache

Chris Wilson chris at chris-wilson.co.uk
Sat Aug 19 10:19:36 UTC 2017


Quoting Kenneth Graunke (2017-08-19 08:26:58)
> This involves a bunch of unnecessary copying, a batch flush, and
> state re-emission.
> ---
>  src/mesa/drivers/dri/i965/brw_program_cache.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c
> index 4dcfd5234df..c1898a05153 100644
> --- a/src/mesa/drivers/dri/i965/brw_program_cache.c
> +++ b/src/mesa/drivers/dri/i965/brw_program_cache.c
> @@ -217,6 +217,8 @@ brw_cache_new_bo(struct brw_cache *cache, uint32_t new_size)
>     struct brw_context *brw = cache->brw;
>     struct brw_bo *new_bo;
>  
> +   perf_debug("Copying to larger program cache - now %d bytes\n", new_size);

Worth a reminder to include the old size?
-Chris


More information about the mesa-dev mailing list