[Mesa-dev] [PATCH 02/18] gallium/radeon: use rectangles for 1D and 2D texture blits

[Dave Airlie]

On 18 August 2017 at 04:31, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>

This break r600 first.

> -       if (attrib) {
> +       switch (type) {
> +       case UTIL_BLITTER_ATTRIB_COLOR:
>                 memcpy(vb+4, attrib->f, sizeof(float)*4);
>                 memcpy(vb+12, attrib->f, sizeof(float)*4);
>                 memcpy(vb+20, attrib->f, sizeof(float)*4);
> +               break;
> +       case UTIL_BLITTER_ATTRIB_TEXCOORD:
> +               vb[4] = attrib->f[0]; /* x1 */
> +               vb[5] = attrib->f[1]; /* y1 */
> +               vb[12] = attrib->f[0]; /* x1 */
> +               vb[13] = attrib->f[3]; /* y2 */
> +               vb[20] = attrib->f[2]; /* x2 */
> +               vb[21] = attrib->f[1]; /* y1 */

Something in here is backwards compared to the normal path.

Making this (0,1) (2, 1), (2, 3) fixes evergreen for me, until the later
patch breaks it again.

This is the same order that set_texcoords_in_vertices uses
before this patch.

Dave.