[Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

[Dave Airlie]

On 21 August 2017 at 23:44, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 21 August 2017 at 14:19, Marek Olšák <maraeo at gmail.com> wrote:
>> On Mon, Aug 21, 2017 at 12:47 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Hi Marek,
>>>
>>> On 20 August 2017 at 01:49, Marek Olšák <maraeo at gmail.com> wrote:
>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>>
>>>> use KILL_IF -1 instead.
>>>> ---
>>> I'm not 100% sure, but I believe virgl uses TGSI to talk with the host driver.
>>> Thus Dave might want to check if the series does not break things on his end.
>>>
>>> Alongside the drop of old opcodes new ones get added in their place.
>>> Thus virgl could use some cap checking, if there isn't one already.
>>>
>>> Then again, I'm not that familiar with the driver to know if/how much
>>> that matters.
>>
>> Gallium and TGSI are unstable interfaces. If some drivers expect them
>> to be stable, it's not our concern.
>>
> Agreed. all I'm saying is "lets give Dave the heads up" ;-)

Thanks,

I've forked TGSI on the backend, so I should be fine, I generally can
fix things up with
tgsi transform if someone breaks things a bit too much.

Dave.