[Mesa-dev] [PATCH 1/6] util: fix valgrind errors when dumping pipe_draw_info

Nicolai Hähnle nhaehnle at gmail.com
Tue Aug 22 15:45:01 UTC 2017


From: Nicolai Hähnle <nicolai.haehnle at amd.com>

Various index-related fields are only initialized when required, so
they should only be dumped in those cases.
---
 src/gallium/auxiliary/util/u_dump_state.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_dump_state.c b/src/gallium/auxiliary/util/u_dump_state.c
index 70bbf5c9fad..c263021a9f6 100644
--- a/src/gallium/auxiliary/util/u_dump_state.c
+++ b/src/gallium/auxiliary/util/u_dump_state.c
@@ -919,9 +919,15 @@ util_dump_draw_info(FILE *stream, const struct pipe_draw_info *state)
    util_dump_member(stream, uint, state, max_index);
 
    util_dump_member(stream, bool, state, primitive_restart);
-   util_dump_member(stream, uint, state, restart_index);
-
-   util_dump_member(stream, ptr, state, index.resource);
+   if (state->primitive_restart)
+      util_dump_member(stream, uint, state, restart_index);
+
+   if (state->index_size) {
+      if (state->has_user_indices)
+         util_dump_member(stream, ptr, state, index.user);
+      else
+         util_dump_member(stream, ptr, state, index.resource);
+   }
    util_dump_member(stream, ptr, state, count_from_stream_output);
 
    if (!state->indirect) {
-- 
2.11.0



More information about the mesa-dev mailing list