[Mesa-dev] [PATCH v2] i965: Issue performance warnings when growing the program cache

[Chris Wilson]

Quoting Kenneth Graunke (2017-08-22 21:47:54)
> This involves a bunch of unnecessary copying, a batch flush, and
> state re-emission.

> ---
>  src/mesa/drivers/dri/i965/brw_program_cache.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c
> index 4dcfd5234df..e9706be8961 100644
> --- a/src/mesa/drivers/dri/i965/brw_program_cache.c
> +++ b/src/mesa/drivers/dri/i965/brw_program_cache.c
> @@ -217,6 +217,9 @@ brw_cache_new_bo(struct brw_cache *cache, uint32_t new_size)
>     struct brw_context *brw = cache->brw;
>     struct brw_bo *new_bo;
>  
> +   perf_debug("Copying to larger program cache: %zu kB -> %u kB\n",
> +              cache->bo->size / 1024, new_size / 1024);

Hmm, z -> size_t but bo->size is uin64_t, so sadly we need "%"PRIu64
-Chris