[Mesa-dev] [PATCH] i965: Do not store SRC after 0 on component control.

[Jason Ekstrand]

Assuming Jenkins is happy with it (both Vulkan and GL),

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Aug 23, 2017 at 2:59 PM, Rafael Antognolli <
rafael.antognolli at intel.com> wrote:

> The PRM SKL-Vol 2b-05.16 says:
>
>    "Within a VERTEX_ELEMENT_STATE structure, if a Component Control
>    field is set to something other than VFCOMP_STORE_SRC, no
>    higher-numbered Component Control fields may be set to
>    VFCOMP_STORE_SRC. In other words, only trailing components can be set
>    to something other than VFCOMP_STORE_SRC."
>
> Since we set the component 1 to VFCOMP_STORE_0 on gen8+, and
> VFCOMP_STORE_IID on gen5+, and we are not using components 2 and 3,
> let's also set them to VFCOMP_STORE_0.
>
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> ---
>  src/intel/blorp/blorp_genX_exec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/blorp/blorp_genX_exec.h
> b/src/intel/blorp/blorp_genX_exec.h
> index 93534169ef..524736fbc0 100644
> --- a/src/intel/blorp/blorp_genX_exec.h
> +++ b/src/intel/blorp/blorp_genX_exec.h
> @@ -395,8 +395,8 @@ blorp_emit_vertex_elements(struct blorp_batch *batch,
>  #else
>        .Component1Control = VFCOMP_STORE_0,
>  #endif
> -      .Component2Control = VFCOMP_STORE_SRC,
> -      .Component3Control = VFCOMP_STORE_SRC,
> +      .Component2Control = VFCOMP_STORE_0,
> +      .Component3Control = VFCOMP_STORE_0,
>  #if GEN_GEN <= 5
>        .DestinationElementOffset = slot * 4,
>  #endif
> --
> 2.13.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170823/421a4b45/attachment.html>