[Mesa-dev] [PATCH 08/47] spirv: Enable FPRoundingMode decorator to nir operations

Alejandro PiƱeiro apinheiro at igalia.com
Thu Aug 24 13:54:23 UTC 2017


From: Jose Maria Casanova Crespo <jmcasanova at igalia.com>

SpvOpFConvert now manages the FPRoundingMode decorator for the
returning values enabling the nir_rounding_mode in the conversion
operation to fp16 values.

v2: Fixed breaking of specialization constants. (Jason Ekstrand)
---
 src/compiler/spirv/vtn_alu.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c
index 7ec30b8a631..b7e1b728895 100644
--- a/src/compiler/spirv/vtn_alu.c
+++ b/src/compiler/spirv/vtn_alu.c
@@ -381,6 +381,26 @@ handle_no_contraction(struct vtn_builder *b, struct vtn_value *val, int member,
    b->nb.exact = true;
 }
 
+static void
+handle_rounding_mode(struct vtn_builder *b, struct vtn_value *val, int member,
+                     const struct vtn_decoration *dec, void *_out_rounding_mode)
+{
+    assert(dec->scope == VTN_DEC_DECORATION);
+    if (dec->decoration != SpvDecorationFPRoundingMode)
+       return;
+    switch (dec->literals[0]) {
+    case SpvFPRoundingModeRTE:
+       *((nir_rounding_mode *) _out_rounding_mode) = nir_rounding_mode_rtne;
+       break;
+    case SpvFPRoundingModeRTZ:
+       *((nir_rounding_mode *) _out_rounding_mode) = nir_rounding_mode_rtz;
+       break;
+    default:
+       unreachable("Not supported rounding mode");
+       break;
+    }
+}
+
 void
 vtn_handle_alu(struct vtn_builder *b, SpvOp opcode,
                const uint32_t *w, unsigned count)
@@ -568,6 +588,18 @@ vtn_handle_alu(struct vtn_builder *b, SpvOp opcode,
       vtn_handle_bitcast(b, val->ssa, src[0]);
       break;
 
+   case SpvOpFConvert: {
+      nir_alu_type src_alu_type = nir_get_nir_type_for_glsl_type(vtn_src[0]->type);
+      nir_alu_type dst_alu_type = nir_get_nir_type_for_glsl_type(type);
+      nir_rounding_mode rounding_mode = nir_rounding_mode_undef;
+
+      vtn_foreach_decoration(b, val, handle_rounding_mode, &rounding_mode);
+      nir_op op = nir_type_conversion_op(src_alu_type, dst_alu_type, rounding_mode);
+
+      val->ssa->def = nir_build_alu(&b->nb, op, src[0], src[1], NULL, NULL);
+      break;
+   }
+
    default: {
       bool swap;
       nir_alu_type src_alu_type = nir_get_nir_type_for_glsl_type(vtn_src[0]->type);
-- 
2.11.0



More information about the mesa-dev mailing list