[Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D

[Roland Scheidegger]

We'll definitely have to adjust some code too, but looks alright to me.
For the series:
Acked-by: Roland Scheidegger <sroland at vmware.com>


Am 23.08.2017 um 18:41 schrieb Nicolai Hähnle:
> Hi all,
> 
> Following the discussion on Timothy's std430 packing series, here's
> a quick proposal to just always use 2D accesses to the CONST file
> in TGSI.
> 
> The first patch should be sufficient for all drivers to accept
> those 2D accesses. It seems that most older drivers simply ignore
> the dimension, and newer ones should handle it directly.
> 
> Subsequent patches modify the producers of TGSI to always use 2D
> constant references. This is mostly done by changing ureg.
> 
> Finally, the last patch adds an assertion to radeonsi to make
> sure all constant references are really 2D. It has survived my
> very superficial initial testing.
> 
> What needs to be tested is:
> - some more drivers
> - Nine
> - TGSI-to-NIR
> 
> You can find the series here: https://urldefense.proofpoint.com/v2/url?u=https-3A__cgit.freedesktop.org_-7Enh_mesa_log_-3Fh-3Dtgsi-2Dconst-2D2d&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=_QIjpv-UJ77xEQY8fIYoQtr5qv8wKrPJc7v7_-CYAb0&m=KWKPHyQBcTYmZoDefBNi8oU710I4OY9MGGBR4KvDMto&s=KPrLO1itcQWh5TgjYW4PSyxC6gZVyGxnBM5_tp1qSCY&e= 
> 
> Please comment/review!
> Thanks,
> Nicolai
> --
>  src/gallium/auxiliary/hud/hud_context.c      |   8 +-
>  src/gallium/auxiliary/nir/tgsi_to_nir.c      |   2 +-
>  src/gallium/auxiliary/postprocess/pp_mlaa.h  |  20 +--
>  src/gallium/auxiliary/tgsi/tgsi_ureg.c       |  22 +--
>  src/gallium/auxiliary/util/u_tests.c         |   4 +-
>  src/gallium/docs/source/screen.rst           |  11 +-
>  src/gallium/drivers/radeon/r600_query.c      |  36 ++--
>  src/gallium/drivers/radeonsi/si_shader.c     |   1 +
>  src/gallium/state_trackers/nine/nine_ff.c    |   2 +-
>  .../state_trackers/nine/nine_shader.c        |  10 +-
>  .../tests/graw/fragment-shader/frag-cb-1d.sh |   8 +-
>  .../tests/graw/vertex-shader/vert-cb-1d.sh   |   8 +-
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp   | 153 +++++++++--------
>  13 files changed, 136 insertions(+), 149 deletions(-)
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=_QIjpv-UJ77xEQY8fIYoQtr5qv8wKrPJc7v7_-CYAb0&m=KWKPHyQBcTYmZoDefBNi8oU710I4OY9MGGBR4KvDMto&s=0IDDvdH4zbWCrIj0PSavhDSx7vVLNukEk0UYXSE_c8s&e= 
>