[Mesa-dev] [PATCH mesa] egl/android: add missing include
robh at kernel.org
Thu Aug 24 18:40:31 UTC 2017
On Thu, Aug 24, 2017 at 10:08 AM, Eric Engestrom
<eric.engestrom at imgtec.com> wrote:
> On Thursday, 2017-08-24 10:02:29 -0500, Rob Herring wrote:
>> On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring <robh at kernel.org> wrote:
>> > On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom
>> > <eric.engestrom at imgtec.com> wrote:
>> >> Cc: Rob Herring <robh at kernel.org>
>> >> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
>> >> ---
>> >> This needs to land before , otherwise the latter will break android.
>> >>  https://lists.freedesktop.org/archives/mesa-dev/2017-August/167428.html
>> >> src/egl/drivers/dri2/platform_android.c | 1 +
>> >> 1 file changed, 1 insertion(+)
>> > For both patches:
>> > Reviewed-by: Rob Herring <robh at kernel.org>
>> Actually, on further examination I think this isn't needed.
> I pushed it a minute before your email: 688d866eca
> (I'm waiting on Emil (and maybe others?) to chime in on the khronos
> header change before I push it.)
>> egl_dri2.h includes system/window.h which in turn includes
>> native_window.h. I'll test out the EGL change without this.
> Personally, I like the include-what-you-use philosophy , so I'd
> rather have this include here anyway.
I agree with that, but we don't actually use anything in
android/native_window.h. native_window.h only provides an opaque
struct. Everything we use is in system/window.h.
With your eglplatform.h change alone and without my O fix, O builds
for me. This is because they kept system/window.h for compatibility.
Really, we're supposed to move to vndk/window.h and would need
libnativewindow to pull that in. However, as long as we support pre-O,
we're not going to be changing.
More information about the mesa-dev