[Mesa-dev] [PATCH] radv: fix predication on gfx9

[Bas Nieuwenhuizen]

Both are

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Aug 25, 2017, at 01:42, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> When I added gfx9 I did it wrong, this fixes it.
> 
> Fixes: 5247b311e9 "radv/gfx9: fix set predication packet."
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/si_cmd_buffer.c
> b/src/amd/vulkan/si_cmd_buffer.c
> index 913ec0e..ef4f926 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -1133,8 +1133,10 @@ si_emit_cache_flush(struct radv_cmd_buffer
> *cmd_buffer)
>  void
>  si_emit_set_predication_state(struct radv_cmd_buffer *cmd_buffer,
>  uint64_t va)
>  {
> -       uint32_t op = PRED_OP(PREDICATION_OP_BOOL64) |
> PREDICATION_DRAW_VISIBLE;
> +       uint32_t op = 0;
>  
> +       if (va)
> +               op = PRED_OP(PREDICATION_OP_BOOL64) |
> PREDICATION_DRAW_VISIBLE;
>  	if (cmd_buffer->device->physical_device->rad_info.chip_class >= GFX9) {
>  		radeon_emit(cmd_buffer->cs, PKT3(PKT3_SET_PREDICATION, 2, 0));
>  		radeon_emit(cmd_buffer->cs, op);
> -- 
> 2.9.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev