[Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

[Kenneth Graunke]

On Thursday, August 24, 2017 9:56:14 PM PDT Tapani Pälli wrote:
> Hi;
> 
> On 08/25/2017 12:30 AM, Kenneth Graunke wrote:
> > On Thursday, August 24, 2017 4:16:39 AM PDT kevin.rogovin at intel.com wrote:
> >> From: Kevin Rogovin <kevin.rogovin at intel.com>
> >>
> >> Special thanks to Eero Tamminen for reporting rasterizer
> >> numbers being twice what it should be for 2xMSAA under
> >> a benchmark.
> >>
> >> Signed-off-by: Kevin Rogovin <kevin.rogovin at intel.com>
> > 
> > Nice catch!  Thanks for fixing this.
> > 
> > Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> > 
> > Ian requested that I run this through a full CTS run before pushing, so
> > that we actually hit all the new visuals, and make sure 2x/16x works as
> > expected.  Assuming that comes back green, I'll plan to push this.
> > 
> 
> I did CI run yesterday with this one, it had 2 failing Piglit tests:
> 
> bin/read-front -samples=16 -auto
> bin/read-front clear-front-first -samples=16 -auto
> 
> not sure what's going on there.
> 
> // Tapani

Oh, that's easily explained.  The CI system uses PIGLIT_PLATFORM=gbm for
Piglit, which doesn't handle frontbuffer rendering.  So, the read-front
tests crash.  We've blacklisted the other variants of that test under
[expected crashes] here:

https://github.com/janesma/mesa_jenkins/blob/master/piglit-test/skl.conf

but the 16x variants go from skipping to crashing.  We just need to
blacklist those as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170824/4df76c4d/attachment.sig>