[Mesa-dev] [PATCH 1/2] mesa: Implement GL_ARB_texture_filter_anisotropic

[Kenneth Graunke]

On Thursday, August 24, 2017 11:40:32 AM PDT Adam Jackson wrote:
> The only difference from the EXT version is bumping the minmax to 16, so
> just hit all the drivers at once.
> 
> v2: Fix driver names, add to 17.3 release notes (Ilia Mirkin)
> 
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  docs/features.txt                            | 4 +++-
>  docs/relnotes/17.3.0.html                    | 1 +
>  src/glx/glxextensions.c                      | 1 +
>  src/glx/glxextensions.h                      | 1 +
>  src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
>  src/mesa/drivers/dri/r200/r200_context.c     | 1 +
>  src/mesa/drivers/dri/radeon/radeon_context.c | 1 +
>  src/mesa/main/extensions.c                   | 1 +
>  src/mesa/main/extensions_table.h             | 1 +
>  src/mesa/main/mtypes.h                       | 1 +
>  src/mesa/main/version.c                      | 2 +-
>  src/mesa/state_tracker/st_extensions.c       | 4 ++++
>  12 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/features.txt b/docs/features.txt
> index 6f57ec26fd..3f91c2daae 100644
> --- a/docs/features.txt
> +++ b/docs/features.txt
> @@ -231,10 +231,12 @@ GL 4.6, GLSL 4.60
>    GL_ARB_shader_draw_parameters                         DONE (i965, nvc0, radeonsi)
>    GL_ARB_shader_group_vote                              DONE (i965, nvc0, radeonsi)
>    GL_ARB_spirv_extensions                               in progress (Nicolai Hähnle, Ian Romanick)
> -  GL_ARB_texture_filter_anisotropic                     not started
> +  GL_ARB_texture_filter_anisotropic                     DONE (i965, nv50, nvc0, r600, radeonsi, softpipe (*), llvmpipe (*))
>    GL_ARB_transform_feedback_overflow_query              DONE (i965/gen6+, radeonsi, llvmpipe, softpipe)
>    GL_KHR_no_error                                       started (Timothy Arceri)
>  
> +(*) softpipe and llvmpipe advertise 16x anisotropy but simply ignore the setting
> +
>  These are the extensions cherry-picked to make GLES 3.1
>  GLES3.1, GLSL ES 3.1 -- all DONE: i965/hsw+, nvc0, radeonsi
>  
> diff --git a/docs/relnotes/17.3.0.html b/docs/relnotes/17.3.0.html
> index 25d02cdca7..8da43f22f0 100644
> --- a/docs/relnotes/17.3.0.html
> +++ b/docs/relnotes/17.3.0.html
> @@ -45,6 +45,7 @@ Note: some of the new features are only available with certain drivers.
>  
>  <ul>
>  <li>GL_ARB_transform_feedback_overflow_query on radeonsi</li>
> +<li>GL_ARB_texture_filter_anisotropic on i965, nv50, nvc0, r600, radeonsi</li>
>  <li>GL_EXT_memory_object on radeonsi</li>
>  <li>GL_EXT_memory_object_fd on radeonsi</li>
>  </ul>
> diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c
> index 22b078ce48..88bf0de3e6 100644
> --- a/src/glx/glxextensions.c
> +++ b/src/glx/glxextensions.c
> @@ -190,6 +190,7 @@ static const struct extension_info known_gl_extensions[] = {
>     { GL(ARB_texture_env_combine),        VER(1,3), Y, N, N, N },
>     { GL(ARB_texture_env_crossbar),       VER(1,4), Y, N, N, N },
>     { GL(ARB_texture_env_dot3),           VER(1,3), Y, N, N, N },
> +   { GL(ARB_texture_filter_anisotropic), VER(0,0), Y, N, N, N },
>     { GL(ARB_texture_mirrored_repeat),    VER(1,4), Y, N, N, N },
>     { GL(ARB_texture_non_power_of_two),   VER(1,5), Y, N, N, N },
>     { GL(ARB_texture_rectangle),          VER(0,0), Y, N, N, N },
> diff --git a/src/glx/glxextensions.h b/src/glx/glxextensions.h
> index 21ad02a44b..2a595516ee 100644
> --- a/src/glx/glxextensions.h
> +++ b/src/glx/glxextensions.h
> @@ -101,6 +101,7 @@ enum
>     GL_ARB_texture_env_combine_bit,
>     GL_ARB_texture_env_crossbar_bit,
>     GL_ARB_texture_env_dot3_bit,
> +   GL_ARB_texture_filter_anisotropic_bit,
>     GL_ARB_texture_mirrored_repeat_bit,
>     GL_ARB_texture_non_power_of_two_bit,
>     GL_ARB_texture_rectangle_bit,

Hi Adam,

I've never seen new GL extensions added to the GLX code like this.  As
far as I know, we haven't done that for any of the other extensions we've
added over the last few years.  I guess this is something related to
indirect GLX?  What does it do?  Should we drop it?

The rest looks good to me, so:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Feel free to push this one - you've got two R-bs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170824/d5daaa10/attachment.sig>