[Mesa-dev] [PATCH 1/2] radv: Remove some intel comments from the resolve code.

[Kenneth Graunke]

On Thursday, August 24, 2017 4:17:25 PM PDT Bas Nieuwenhuizen wrote:
> These are clearly not applicable to radv.
> ---
>  src/amd/vulkan/radv_meta_resolve.c    | 7 -------
>  src/amd/vulkan/radv_meta_resolve_cs.c | 7 -------
>  src/amd/vulkan/radv_meta_resolve_fs.c | 7 -------
>  3 files changed, 21 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c
> index 6023e0f8999..dd811c25142 100644
> --- a/src/amd/vulkan/radv_meta_resolve.c
> +++ b/src/amd/vulkan/radv_meta_resolve.c
> @@ -612,13 +612,6 @@ radv_cmd_buffer_resolve_subpass(struct radv_cmd_buffer *cmd_buffer)
>  
>  		radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
>  
> -		/* Subpass resolves must respect the render area. We can ignore the
> -		 * render area here because vkCmdBeginRenderPass set the render area
> -		 * with 3DSTATE_DRAWING_RECTANGLE.
> -		 *
> -		 * XXX(chadv): Does the hardware really respect
> -		 * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
> -		 */
>  		emit_resolve(cmd_buffer,
>  			     &(VkOffset2D) { 0, 0 },
>  			     &(VkExtent2D) { fb->width, fb->height });
> diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c b/src/amd/vulkan/radv_meta_resolve_cs.c
> index d20d04231ed..da6ca76b6d4 100644
> --- a/src/amd/vulkan/radv_meta_resolve_cs.c
> +++ b/src/amd/vulkan/radv_meta_resolve_cs.c
> @@ -529,13 +529,6 @@ radv_cmd_buffer_resolve_subpass_cs(struct radv_cmd_buffer *cmd_buffer)
>  
>  		radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
>  
> -		/* Subpass resolves must respect the render area. We can ignore the
> -		 * render area here because vkCmdBeginRenderPass set the render area
> -		 * with 3DSTATE_DRAWING_RECTANGLE.
> -		 *
> -		 * XXX(chadv): Does the hardware really respect
> -		 * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
> -		 */
>  		emit_resolve(cmd_buffer,
>  			     src_iview,
>  			     dst_iview,
> diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/radv_meta_resolve_fs.c
> index 2f745f0ea09..373dd9665a7 100644
> --- a/src/amd/vulkan/radv_meta_resolve_fs.c
> +++ b/src/amd/vulkan/radv_meta_resolve_fs.c
> @@ -633,13 +633,6 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
>  
>  		radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
>  
> -		/* Subpass resolves must respect the render area. We can ignore the
> -		 * render area here because vkCmdBeginRenderPass set the render area
> -		 * with 3DSTATE_DRAWING_RECTANGLE.
> -		 *
> -		 * XXX(chadv): Does the hardware really respect
> -		 * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
> -		 */
>  		emit_resolve(cmd_buffer,
>  			     src_iview,
>  			     dest_iview,
> 

Yeah!  Down with the 3DSTATE_DRAWING_RECTANGLE comments, and bring on the
S_028B50_DONUT_SPLIT and V_028B6C_DISTRIBUTION_MODE_DONUTS comments! :)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170824/60822333/attachment.sig>