[Mesa-dev] [PATCH] egl/drm: Don't "fall back" to /dev/dri/card0 if the first open fails

Emil Velikov emil.l.velikov at gmail.com
Fri Aug 25 13:41:02 UTC 2017


On 24 August 2017 at 19:52, Adam Jackson <ajax at redhat.com> wrote:
> The snprintf stuff here already constructs the right name for the device
> node, and if it doesn't, you configured Mesa wrong, don't do that.
>
I think the idea was that "snprintf can fail" even though in practise
it will never do.
In all fairness how much to care in that case.

Should we drop the "if (n != -1 && n < sizeof(buf))" part as well with
this patch?

-Emil


More information about the mesa-dev mailing list