[Mesa-dev] [PATCH] st/query: init result data with 0

[Ilia Mirkin]

Why is this necessary? If data is not initialized, then presumably
pipe->get_query_result will have returned false.

On Fri, Aug 25, 2017 at 7:15 PM, Karol Herbst <karolherbst at gmail.com> wrote:
> otherwise the result might contain random data.
>
> fixes on nvc0:
>  * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values
>  * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_non_rendering_commands_do_not_affect_queries
>
> Signed-off-by: Karol Herbst <karolherbst at gmail.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/state_tracker/st_cb_queryobj.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_cb_queryobj.c b/src/mesa/state_tracker/st_cb_queryobj.c
> index 4c25724b5d..9a65fe7bd9 100644
> --- a/src/mesa/state_tracker/st_cb_queryobj.c
> +++ b/src/mesa/state_tracker/st_cb_queryobj.c
> @@ -211,7 +211,7 @@ get_query_result(struct pipe_context *pipe,
>                   struct st_query_object *stq,
>                   boolean wait)
>  {
> -   union pipe_query_result data;
> +   union pipe_query_result data = { 0 };
>
>     if (!stq->pq) {
>        /* Only needed in case we failed to allocate the gallium query earlier.
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev