[Mesa-dev] [PATCH 1/2] nir: Fix some whatespace

Jason Ekstrand jason at jlekstrand.net
Sat Aug 26 04:14:28 UTC 2017


On Fri, Aug 25, 2017 at 8:59 PM, Matt Turner <mattst88 at gmail.com> wrote:

> Both are
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> (Typo in the title of this patch)
>
> Should 2/2 go to stable? I'm not really sure how that code gets used.
>

Probably wouldn't hurt.  Doing a quick grep for the function, I don't see
anywhere that it actually matters for those two system values.  We use it
in nir_gather_info to fill out system_values_used and in brw_fs_nir because
we have a table of pre-computed system values.  However, since they get
lowered earlier on, I don't think it matters in practice.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170825/3910e5c1/attachment.html>


More information about the mesa-dev mailing list