[Mesa-dev] [PATCH 1/2] util: inline u_vector.c within the header

[Emil Velikov]

On 25 August 2017 at 21:20, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Inlining the implementation does not cause additional overhead in
> terms of build time while the binary is increased only marginally (~1k)
>
> At the same time the compiler should be able to optimise better, although
> this is not a path where we'll notice much difference.
>
> Use a local u_is_power_of_two to avoid pulling u_math.h. Latter of
> which would require updating 5+ locations to have an extra -I directive.
>
> Doing this will allow us to address a unrelated issue, as mentioned in
> the report below.
>
> Cc: "17.2" <mesa-stable at lists.freedesktop.org>
> Cc: Daniel Stone <daniels at collabora.com>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101851
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Note this patch and 2/2 are effectively superseded by the following.

https://patchwork.freedesktop.org/patch/173778/

-Emil