[Mesa-dev] [PATCH 06/10] egl: add juicy comment about WL_bind_wayland_display + wl_drm/wl_dmabuf

Emil Velikov emil.l.velikov at gmail.com
Sun Aug 27 10:20:31 UTC 2017

From: Emil Velikov <emil.velikov at collabora.com>

AFAICT the extension only makes sense/can work with wl_drm.
If/as we decide to drop it there's a lot of subtleties (borderline
hacks) that can be dropped.

Add a comment with a few keywords to grep.

Cc: Daniel Stone <daniels at collabora.com>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
I think the comment is accurate, but do correct me if not.
I'm not advocating/lobbying about any removal, just preparing for the
sweet sweet moment ...
 src/egl/drivers/dri2/egl_dri2.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h
index 4a52b490a87..a48ea2c662b 100644
--- a/src/egl/drivers/dri2/egl_dri2.h
+++ b/src/egl/drivers/dri2/egl_dri2.h
@@ -428,6 +428,11 @@ const __DRIconfig *
 dri2_get_dri_config(struct dri2_egl_config *conf, EGLint surface_type,
                     EGLenum colorspace);
+/* XXX: WL_bind_wayland_display is only useful/applicable for wl_drm.
+ * Can/should we consider deprecating it as we iron most issues in wl_dmabuf?
+ * How about wl_drm overall - this will allow us to remove a lot of icky code.
+ * Search for server_drm, driver_name and authenticate.
+ */
 static inline void
 dri2_set_WL_bind_wayland_display(_EGLDriver *drv, _EGLDisplay *disp)

More information about the mesa-dev mailing list