[Mesa-dev] [PATCH 2/2] i915/fpc_translate: Remove a few unused variables

Kenneth Graunke kenneth at whitecape.org
Mon Aug 28 05:11:09 UTC 2017


On Friday, August 25, 2017 12:04:36 AM PDT Eduardo Lima Mitev wrote:
> ---
>  src/gallium/drivers/i915/i915_fpc_translate.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/src/gallium/drivers/i915/i915_fpc_translate.c b/src/gallium/drivers/i915/i915_fpc_translate.c
> index a9601e82ca9..2eaa1e64ef7 100644
> --- a/src/gallium/drivers/i915/i915_fpc_translate.c
> +++ b/src/gallium/drivers/i915/i915_fpc_translate.c
> @@ -77,21 +77,6 @@ static unsigned passthrough_program[] =
>     0
>  };
>  
> -
> -/* 1, -1/3!, 1/5!, -1/7! */
> -static const float scs_sin_constants[4] = { 1.0,
> -   -1.0f / (3 * 2 * 1),
> -   1.0f / (5 * 4 * 3 * 2 * 1),
> -   -1.0f / (7 * 6 * 5 * 4 * 3 * 2 * 1)
> -};
> -
> -/* 1, -1/2!, 1/4!, -1/6! */
> -static const float scs_cos_constants[4] = { 1.0,
> -   -1.0f / (2 * 1),
> -   1.0f / (4 * 3 * 2 * 1),
> -   -1.0f / (6 * 5 * 4 * 3 * 2 * 1)
> -};
> -
>  /* 2*pi, -(2*pi)^3/3!, (2*pi)^5/5!, -(2*pi)^7/7! */
>  static const float sin_constants[4] = { 2.0 * M_PI,
>     -8.0f * M_PI * M_PI * M_PI / (3 * 2 * 1),
> @@ -495,7 +480,6 @@ i915_translate_instruction(struct i915_fp_compile *p,
>                             const struct i915_full_instruction *inst,
>                             struct i915_fragment_shader *fs)
>  {
> -   uint writemask;
>     uint src0, src1, src2, flags;
>     uint tmp = 0;
>  
> 

Patch 1 is Acked-by: Kenneth Graunke <kenneth at whitecape.org>

This patch should use i915g as the prefix, i.e.
"i915g: Remove a few unused variables"

It is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170827/53b6b55d/attachment.sig>


More information about the mesa-dev mailing list