[Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

[Emil Velikov]

On 28 August 2017 at 03:33, Leo Liu <leo.liu at amd.com> wrote:
> On 08/27/2017 01:52 PM, Emil Velikov wrote:
>>
>> On 25 August 2017 at 18:17, Leo Liu <leo.liu at amd.com> wrote:
>>>
>>> Signed-off-by: Leo Liu <leo.liu at amd.com>
>>> ---
>>>   src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/gallium/drivers/radeon/radeon_uvd.c
>>> b/src/gallium/drivers/radeon/radeon_uvd.c
>>> index 648a493b59..228f654af1 100644
>>> --- a/src/gallium/drivers/radeon/radeon_uvd.c
>>> +++ b/src/gallium/drivers/radeon/radeon_uvd.c
>>> @@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct
>>> ruvd_decoder *dec, struct pipe_mjpeg_p
>>>                          continue;
>>>
>>>                  buf[size++] = i;
>>> -               memcpy((buf + size),
>>> &pic->quantization_table.quantiser_table, 64);
>>> +               memcpy((buf + size),
>>> &pic->quantization_table.quantiser_table[i], 64);
>>
>> Can you mention a bit in the commit message "The index was missing"
>> and add a Fixes/stable tag?
>
> Sure. Is "Fixes" enough ? since the original patch this fix based on is not
> in stable branch yet.
>
Fixes should be enough, but sometimes it's not easy to track exact
offending commit.
Here that's easy ;-)

Fixes: 130d1f456b8 ("radeon/uvd: reconstruct MJPEG bitstream")

Thanks
Emil