[Mesa-dev] [PATCH 00/10] egl: mixed bag of fixes/cleanups

[Daniel Stone]

Hi Emil,

On 27 August 2017 at 11:20, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>   egl: simplify refcounting after screen creation

Acked-by: Daniel Stone <daniels at collabora.com>

>   egl/wayland: plug leaks in dri2_wl_create_window_surface() error path
>   egl/wayland: polish object teardown in dri2_wl_destroy_surface

Reviewed-by: Daniel Stone <daniels at collabora.com>

>   egl: allow RGB565 formats in eglCreateWaylandBufferFromImageWL

I've been avoiding trying to expand use of this API, in all honesty.

>   egl/wayland: update comment to reflect wl_dmabuf presence

Reviewed-by: Daniel Stone <daniels at collabora.com>

>   egl: add juicy comment about WL_bind_wayland_display +
>     wl_drm/wl_dmabuf

It depends on a couple of things, really. Firstly, on Mesa's general
feature deprecation schedule. Secondly, on external support
(Weston/Mutter/Enlightenment are fine, no support yet in
KWin/WLC/Smithay/...). Thirdly, on how cleanly we can separate it. If
we can break out all the BindWaylandDisplay code more than we already
have, it might be easier to maintain. And lastly, on NVIDIA: I believe
being a Streams provider requires BindWaylandDisplay, so we might need
that to be replaced before we can rip it out of Mesa.

Having the comment expanded to cover these might be nice.

>   egl/wayland: set correct format with wl_dmabuf as wl_drm is missing

Reviewed-by: Daniel Stone <daniels at collabora.com>

>   egl/wayland: remove dri2_surf width/height double init.

Acked-by: Daniel Stone <daniels at collabora.com>

>   egl/wayland: group wl_win specific code together
>   egl/wayland: make sure HAS_$FORMAT is set for wl_dmabuf

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel