[Mesa-dev] [PATCH 01/19] configure: Add and use AX_CHECK_COMPILE_FLAG

[Emil Velikov]

On 28 August 2017 at 22:57, Matt Turner <mattst88 at gmail.com> wrote:

> -    # Flags to help ensure that certain portions of the code -- and only those
> -    # portions -- can be built with MSVC:
> -    # - src/util, src/gallium/auxiliary, rc/gallium/drivers/llvmpipe, and
> -    # - non-Linux/Posix OpenGL portions needs to build on MSVC 2013 (which
> -    #   supports most of C99)
> -    # - the rest has no compiler compiler restrictions
> -    MSVC2013_COMPAT_CFLAGS="-Werror=pointer-arith"
> -    MSVC2013_COMPAT_CXXFLAGS="-Werror=pointer-arith"
> -
Can you please preserve the comment about the MSVC2013 flags?
With that the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Mildly curious:
Did you pipe the series through ezbench for perf testing?
Wondering if the inline and fabsf -> babs changes made any noticeable impact.

-Emil