[Mesa-dev] [PATCH 0/8] Resend of preprocessor series

Emil Velikov emil.l.velikov at gmail.com
Wed Aug 30 09:40:46 UTC 2017


Hi Thomas,

On 29 August 2017 at 20:56, Thomas Helland <thomashelland90 at gmail.com> wrote:
> This is a resend of the string buffer implementation and
> related patches sent out back in May. I've done one more
> change to the string buffer; using u_string.h for a compatible
> vsnprintf version to reduce the code even more. I've not been
> able to test this due to two build breakages (xmlpool and dri)
> that I'm still trying to figure out of. But since I promised
> to send these out this evening, I'm sending them untested.
> I did test them thoroughly the last time around though,
> so I believe it should be mostly good as long as I haven't
> messed up the rebasing. I believe the string buffer part of
> the series is the most important; the rest I've not really
> gotten around to performance test much.
>
How does this relate to Nicolai's stringbuf patches?
Would be great to see if we can "get away" only with one and focus on that.

That said, a couple of comments incoming (alongside fix for the build issue).
Please don't bother addressing them until this "vs" stringbuf is resolved.

-Emil


More information about the mesa-dev mailing list