[Mesa-dev] [PATCH 2/2] st/glx: add support for GLX_ARB_create_context_no_error

[Adam Jackson]

On Thu, 2017-08-31 at 11:41 -0400, Adam Jackson wrote:
> On Thu, 2017-08-03 at 20:07 +0200, Grigori Goronzy wrote:
> > @@ -981,6 +983,8 @@ XMesaContext XMesaCreateContext( XMesaVisual v,
> > XMesaContext share_list,
> >        attribs.flags |= ST_CONTEXT_FLAG_DEBUG;
> >     if (contextFlags & GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB)
> >        attribs.flags |= ST_CONTEXT_FLAG_ROBUST_ACCESS;
> > +   if (noError)
> > +      attribs.flags |= ST_CONTEXT_FLAG_NO_ERROR;
> >  
> >     switch (profileMask) {
> >     case GLX_CONTEXT_CORE_PROFILE_BIT_ARB:
> 
> This seems weird to me. Why add an argument when there's already a
> flag bit for this?

My mistake. For st it's a flag, for GL it's an attribute.

- ajax