[Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

[Eric Engestrom]

On Friday, 2017-12-01 17:08:53 +0200, vadim.shovkoplias at gmail.com wrote:
> From: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
> 
> In this condition dri2_dpy->driver_name string always equals
> NULL, so call to free() is useless
> 
> Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>

Reviewed and pushed :)

Are you finding all of these by inspection, or are you using a tool?

> ---
>  src/egl/drivers/dri2/platform_x11.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c
> index c49cb1f..8ede590b 100644
> --- a/src/egl/drivers/dri2/platform_x11.c
> +++ b/src/egl/drivers/dri2/platform_x11.c
> @@ -704,7 +704,6 @@ dri2_x11_connect(struct dri2_egl_display *dri2_dpy)
>  
>     if (dri2_dpy->driver_name == NULL) {
>        close(dri2_dpy->fd);
> -      free(dri2_dpy->driver_name);
>        free(connect);
>        return EGL_FALSE;
>     }
> -- 
> 2.7.4
>