[Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts
ajax at redhat.com
Fri Dec 1 21:02:24 UTC 2017
On Tue, 2017-11-14 at 14:03 -0800, Ian Romanick wrote:
> On 11/14/2017 12:13 PM, Adam Jackson wrote:
> > diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c
> > index 933b5d9ecd..42e7996e37 100644
> > --- a/src/glx/glx_pbuffer.c
> > +++ b/src/glx/glx_pbuffer.c
> > @@ -272,7 +272,7 @@ DestroyDRIDrawable(Display *dpy, GLXDrawable drawable, int destroy_xdrawable)
> > * 10. Given that, this routine should try to use an array on the stack to
> > * capture the reply rather than always calling Xmalloc.
> > */
> > -static int
> > +int
> > GetDrawableAttribute(Display * dpy, GLXDrawable drawable,
> I'm trying to decide whether or not this needs a __glX prefix now. Yes?
Eh, sure. Anyone whose toolchain still doesn't have visibility control
is losing pretty hard, but we may as well be consistent.
> Other than that, this patch is
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Merged 1 2 and 5, will respin the rest.
More information about the mesa-dev