[Mesa-dev] [PATCH v2 18/32] vulkan/wsi: Refactor result handling in queue_present

[Chad Versace]

On Tue 28 Nov 2017, Jason Ekstrand wrote:
> ---
>  src/vulkan/wsi/wsi_common.c | 54 +++++++++++++++++++++++----------------------
>  1 file changed, 28 insertions(+), 26 deletions(-)
> 
> diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c
> index 5920359..f149846 100644
> --- a/src/vulkan/wsi/wsi_common.c
> +++ b/src/vulkan/wsi/wsi_common.c
> @@ -514,14 +514,14 @@ wsi_common_queue_present(const struct wsi_device *wsi,
>                           int queue_family_index,
>                           const VkPresentInfoKHR *pPresentInfo)
>  {
> -   VkResult result = VK_SUCCESS;
> +   VkResult final_result = VK_SUCCESS;

Yes please. The goto improves this code.

Reviewed-by: Chad Versace <chadversary at chromium.org>