[Mesa-dev] [PATCH v2 25/32] vulkan/wsi: move swapchain create/destroy to common code

[Chad Versace]

On Tue 28 Nov 2017, Jason Ekstrand wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> v2 (Jason Ekstrand):
>  - Rebase
>  - Alter the names of the helpers to better match the vulkan entrypoints
>  - Use the helpers in anv
> ---
>  src/amd/vulkan/radv_wsi.c   | 42 ++++++++----------------------------------
>  src/intel/vulkan/anv_wsi.c  | 35 +++++------------------------------
>  src/vulkan/wsi/wsi_common.c | 38 ++++++++++++++++++++++++++++++++++++++
>  src/vulkan/wsi/wsi_common.h | 12 ++++++++++++
>  4 files changed, 63 insertions(+), 64 deletions(-)

> @@ -115,6 +115,9 @@ fail:
>  void
>  wsi_swapchain_finish(struct wsi_swapchain *chain)
>  {
> +   for (unsigned i = 0; i < ARRAY_SIZE(chain->fences); i++)
> +      chain->wsi->DestroyFence(chain->device, chain->fences[i], &chain->alloc);
> +

Yes. I've been waiting to see DestroyFence here since patch 17.

>     for (uint32_t i = 0; i < chain->wsi->queue_family_count; i++) {
>        chain->wsi->DestroyCommandPool(chain->device, chain->cmd_pools[i],
>                                       &chain->alloc);
> @@ -485,6 +488,41 @@ wsi_destroy_image(const struct wsi_swapchain *chain,

Patch 25 is
Reviewed-by: Chad Versace <chadversary at chromium.org>