[Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

[Emil Velikov]

On 4 December 2017 at 18:25, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2017-12-04 10:14:15)
>> On 4 December 2017 at 18:06, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > Quoting Emil Velikov (2017-12-04 05:20:03)
>> >> On 29 November 2017 at 00:56, Dylan Baker <dylan at pnwbakers.com> wrote:
>> >> > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>> >> > ---
>> >> >  meson.build                               | 11 +++++++++++
>> >> >  meson_options.txt                         |  7 +++++++
>> >> >  src/gallium/drivers/etnaviv/meson.build   |  2 +-
>> >> >  src/gallium/drivers/freedreno/meson.build |  1 +
>> >> >  src/gallium/drivers/nouveau/meson.build   |  2 +-
>> >> >  src/gallium/drivers/r300/meson.build      |  4 +++-
>> >> >  src/gallium/targets/dri/meson.build       |  2 +-
>> >> I'd stick with the autotools approach and add the link to the
>> >> gallium/aux module.
>> >> There are simply too many combinations where lmsensors can be utilised.
>> >>
>> >> -Emil
>> >
>> > lmsensors is in one of the variables in src/gallium/Automake.inc, I copied the
>> > location from there, if it would be better to link just to aux we can do that
>> > instead.
>> >
>> Memory is failing - forgot I moved that one.
>>
>> If possible I'd recommend having something like
>> GALLIUM_COMMON_LIB_DEPS - a group of shared libraries that all final
>> binaries link against.
>> Alternatively moving it to src/gallium/auxiliary/meson.build should also work.
>>
>> Thanks
>> Emil
>
> One of the things that Eric suggested and I'm liking more now that we getting
> closer to having everything building (and the complexity is going up), is just
> replacing the individual `dep_foo` with bigger `deq_egl` sort of groups that
> just have all of the egl deps in them already. Alternatively meson is working on
> caching dependency lookups, so in the future it may be possible to stop passing
> around dependencies at all and just have `dependency('foo')` in each target with
> zero overhead.

Yes having a small (ideally single) 'include' and 'library" was one of
the reasons behind the Automake.inc files.
Even if we ignore the speed for a moment, keeping things short keeps
it simple and more robust ;-)

-Emil