[Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

[Ilia Mirkin]

On Tue, Dec 5, 2017 at 8:18 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Rob,
>
> On 5 December 2017 at 12:54, Rob Clark <robdclark at gmail.com> wrote:
>> This is a bit sad/annoying.  But with current GPU firmware (at least on
>> a5xx) we can support both draw-indirect and base-instance.  But we can't
>> support draw-indirect with a non-zero base-instance specified.  So add a
>> driconf option to hide the extension from games that are known to use
>> both.
>>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>> ---
>> Tbh, I'm also not really sure what to do when/if we got updated firmware
>> which handled draw-indirect with base-instance, since we'd need to make
>> this option conditional on fw version.  For STK that probably isn't a
>> big deal since it doesn't use draw-indirect in a particularly useful way
>> (the indirect buffer is generated on CPU).
>>
> Couldn't freedreno just return 0 for PIPE_CAP_DRAW_INDIRECT (aka
> disable the extension) as it detects buggy FW?
> This is what radeons have been doing as they encounter iffy firmware or LLVM.
>
> AFAICT freedreno doesn't do GL 4.0 or GLES 3.1 so one should be safe.

Rob is this -><- close to ES 3.1, so that's not a great option.