[Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

[Emil Velikov]

On 5 December 2017 at 20:03, Adam Jackson <ajax at redhat.com> wrote:
> On Thu, 2017-11-30 at 16:10 +0000, Emil Velikov wrote:
>> On 14 November 2017 at 20:13, Adam Jackson <ajax at redhat.com> wrote:
>>
>> > @@ -562,6 +562,10 @@ dri2_convert_glx_attribs(unsigned num_attribs,
>> > const uint32_t *attribs,
>> >              return false;
>> >           }
>> >           break;
>> > +      case GLX_SCREEN:
>> > +         /* Implies GLX_EXT_no_config_context */
>> > +         *render_type = GLX_DONT_CARE;
>> > +         break;
>>
>> We should fall-through (and fail) when GLX_SCREEN is set but the
>> extension is missing.
>
> Nah. This function does not make reference to the screen we're trying
> to create a context for. And, for direct contexts (that call this
> conversion helper) this extension is now always present anyway.
>
Hmm you're right - having adding check is pain in the rear and an overkill.

-Emil