[Mesa-dev] [PATCH 2/3] glx: Lift sending the MakeCurrent request to top-level code (v2)

[Adam Jackson]

On Wed, 2017-12-06 at 15:14 +0000, Emil Velikov wrote:

> > -      if (gc->vtable->bind(gc, oldGC, draw, read) != Success) {
> > +      if (gc->vtable->bind(gc, gc, draw, read) != Success) {
> >           __glXSetCurrentContextNull();
> 
> This line seems inconsistent/wrong.
> 
> The glXMakeCurrent manpage says "If False is returned, the previously
> current rendering context and drawable (if any) remain unchanged."

Ugh. That's not really possible to get perfectly right, there are
unrecoverable states (think MakeCurrent away from a context that's been
deleted, or whose current drawable is a destroyed window). Still, I
suppose we should try at least a little.

- ajax