[Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

[Eric Engestrom]

On Thursday, 2017-12-07 10:16:01 -0800, Dylan Baker wrote:
> Quoting Eric Engestrom (2017-12-07 09:49:30)
> > On Thursday, 2017-12-07 09:32:39 -0800, Dylan Baker wrote:
> > > I don't suppose someone would like to ack this?
> > > 
> > > Quoting Dylan Baker (2017-12-04 14:05:12)
> > > > Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support")
> > > > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> > > > ---
> > > >  src/gallium/targets/libgl-xlib/meson.build | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/src/gallium/targets/libgl-xlib/meson.build b/src/gallium/targets/libgl-xlib/meson.build
> > > > index 825b7b4a0f1..d0241a59ebe 100644
> > > > --- a/src/gallium/targets/libgl-xlib/meson.build
> > > > +++ b/src/gallium/targets/libgl-xlib/meson.build
> > > > @@ -62,7 +62,7 @@ libgl = shared_library(
> > > >      libxlib, libws_xlib, libsoftpipe, libtrace, librbug, libglapi_static,
> > > >      libgallium, libmesa_util, libmesa_gallium, gallium_xlib_link_with,
> > > >    ],
> > > > -  dependencies : [dep_clock, dep_unwind, gallium_xlib_depends],
> > > > +  dependencies : [dep_clock, dep_unwind, dep_lmsensors, gallium_xlib_depends],
> > 
> > needed because `link_with: libgallium`
> > 
> > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > 
> > I'm not clear on `link_with:` though: shouldn't that track deps so that
> > we don't need to do this manually?
> > 
> > > >    install : true,
> > > >    version : '1.5.0',
> > > >  )
> > > > -- 
> > > > 2.15.0
> > > > 
> 
> It would if lmsensors was added to libgallium. Maybe it makes more sense to just
> remove the dependencies from the targets that include libgallium and add it to
> libgallium instead? Emil suggested that.

Yeah, I agree. I'd say land this for now, but you can do another patch
to remove all of them and add the dep once in libgallium.