[Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

[Roland Scheidegger]

Am 11.12.2017 um 18:42 schrieb Brian Paul:
> ---
>  src/gallium/auxiliary/cso_cache/cso_context.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c
> index df5543c..dd9821e 100644
> --- a/src/gallium/auxiliary/cso_cache/cso_context.c
> +++ b/src/gallium/auxiliary/cso_cache/cso_context.c
> @@ -592,6 +592,11 @@ enum pipe_error cso_set_rasterizer(struct cso_context *ctx,
>                                                         (void*)templ, key_size);
>     void *handle = NULL;
>  
> +   /* We can't have both point_quad_rasterization (sprites) and point_smooth
> +    * (round AA points) enabled at the same time.
> +    */
> +   assert(!(templ->point_quad_rasterization && templ->point_smooth));
> +
>     if (cso_hash_iter_is_null(iter)) {
>        struct cso_rasterizer *cso = MALLOC(sizeof(struct cso_rasterizer));
>        if (!cso)
> 

I'm ok with not allowing it, but it contradicts the gallium docs (which
basically specify that point_quad_rasterization takes precedence over
point_smooth). Albeit in another paragraph, the docs also state it's an
error for mismatches in these states, so I suppose it's ok, but probably
a doc clarification would be nice.
Either way,
Reviewed-by: Roland Scheidegger <sroland at vmware.com>